Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, cmd, trie: pbss fix release v1.13.6 and v1.13.8 #618

Merged
merged 2 commits into from
Nov 11, 2024
Merged

core, cmd, trie: pbss fix release v1.13.6 and v1.13.8 #618

merged 2 commits into from
Nov 11, 2024

Commits on Nov 9, 2024

  1. trie: remove inconsistent trie nodes during sync in path mode (#28595) 

    This fixes a database corruption issue that could occur during state healing.
When sync is aborted while certain modifications were already committed, and a reorg occurs, the database would contain incorrect trie nodes stored by path.
These nodes need to detected/deleted in order to obtain a complete and fully correct state after state healing.

---------

Co-authored-by: Felix Lange <[email protected]>
    @rjl493456442 @fjl @Francesco4203
    2 people authored and Francesco4203 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    aff0493 View commit details
    Browse the repository at this point in the history

  2. core, cmd, trie: fix the condition of pathdb initialization (#28718) 

    Original problem was caused by #28595, where we made it so that as soon as we start to sync, the root of the disk layer is deleted. That is not wrong per se, but another part of the code uses the "presence of the root" as an init-check for the pathdb. And, since the init-check now failed, the code tried to re-initialize it which failed since a sync was already ongoing.

The total impact being: after a state-sync has begun, if the node for some reason is is shut down, it will refuse to start up again, with the error message: `Fatal: Failed to register the Ethereum service: waiting for sync.`.

This change also modifies how `geth removedb` works, so that the user is prompted for two things: `state data` and `ancient chain`. The former includes both the chaindb aswell as any state history stored in ancients.

---------

Co-authored-by: Martin HS <[email protected]>
    @rjl493456442 @holiman @Francesco4203
    2 people authored and Francesco4203 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    9d2dc76 View commit details
    Browse the repository at this point in the history