Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RNSCommission): allow send 0 #286

Open
wants to merge 9 commits into
base: feature/bulk-renew
Choose a base branch
from
Open

fix(RNSCommission): allow send 0 #286

wants to merge 9 commits into from
+255 −565

Conversation

TuDo1403
Copy link
Collaborator

@TuDo1403 TuDo1403 commented Nov 5, 2024 •
edited
Loading

Description

This PR allow RNSCommission to return instead of revert if sent amount is 0.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@TuDo1403 TuDo1403 changed the title Fix/return when zero rns commission fix(RNSCommission): allow send 0 Nov 5, 2024
@TuDo1403 TuDo1403 force-pushed the fix/return-when-zero-rns-commission branch from d2b1387 to 9a06dcf Compare November 5, 2024 08:40
@TuDo1403 TuDo1403 force-pushed the fix/return-when-zero-rns-commission branch from 9a06dcf to d26bef2 Compare November 5, 2024 08:41
huyhuynh3103
huyhuynh3103 previously approved these changes Nov 5, 2024
View reviewed changes
Copy link

@huyhuynh3103 huyhuynh3103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtaskymaviscom khanhtaskymaviscom khanhtaskymaviscom approved these changes

@huyhuynh3103 huyhuynh3103 huyhuynh3103 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TuDo1403 @huyhuynh3103 @khanhtaskymaviscom @tringuyenskymavis