Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conflict reducer name #439

Merged
merged 4 commits into from
Feb 28, 2024
Merged

fix: conflict reducer name #439

merged 4 commits into from
Feb 28, 2024

Conversation

gca-axelor
Copy link
Contributor

RM#75733

@gca-axelor gca-axelor changed the title fix: conflict name for project reducer in hr and helpdesk module fix: conflict reducer name Feb 22, 2024
@gca-axelor gca-axelor self-assigned this Feb 22, 2024
@gca-axelor gca-axelor added 🚧 Doing Development in progress 🐛 Bug Bug fix ✅ Done Development done, awaiting feedback labels Feb 22, 2024
@gca-axelor gca-axelor assigned vhu-axelor and unassigned gca-axelor Feb 22, 2024
@gca-axelor gca-axelor removed the 🚧 Doing Development in progress label Feb 22, 2024
vhu-axelor
vhu-axelor suggested changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@vhu-axelor vhu-axelor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to change the slices name in several components, like in ProductSearchBar, which causes app crash, like when you go to the Active timer screen. Do a global search on VSCode for "state.project" and "state.timer".
Plus, don't forget the changelog.

@vhu-axelor vhu-axelor assigned gca-axelor and unassigned vhu-axelor Feb 23, 2024
@vhu-axelor vhu-axelor added 🪃 Feedback Feedback given by maintainer and removed ✅ Done Development done, awaiting feedback labels Feb 23, 2024
@gca-axelor gca-axelor assigned vhu-axelor and unassigned gca-axelor Feb 26, 2024
@gca-axelor gca-axelor added ✅ Done Development done, awaiting feedback and removed 🪃 Feedback Feedback given by maintainer labels Feb 26, 2024
@vhu-axelor vhu-axelor added the Pair approved 🌟 Pair approved changes label Feb 26, 2024
@vhu-axelor vhu-axelor assigned lme-axelor and unassigned vhu-axelor Feb 26, 2024
@lme-axelor lme-axelor added the Approved 🌟 Can be merged after pipeline succeed label Feb 28, 2024
@lme-axelor lme-axelor merged commit 8ae331d into axelor:dev Feb 28, 2024
5 checks passed
vhu-axelor pushed a commit to vhu-axelor/axelor-mobile that referenced this pull request Feb 29, 2024
@gca-axelor @vhu-axelor
fix: reducer name conflicts (axelor#439)
06eefac 
* RM#75733
lme-axelor pushed a commit that referenced this pull request Mar 13, 2024
@gca-axelor @lme-axelor
fix: reducer name conflicts (#439)
053ad1c 
* RM#75733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhu-axelor vhu-axelor vhu-axelor approved these changes

Assignees

@lme-axelor lme-axelor

Labels
Approved 🌟 Can be merged after pipeline succeed 🐛 Bug Bug fix ✅ Done Development done, awaiting feedback Pair approved 🌟 Pair approved changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gca-axelor @vhu-axelor @lme-axelor