Remove webhook blocking etcd scaling #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahreehong
force-pushed
the
etcd-scaling
branch
from
4f7c919 to
d879a12
Compare
ahreehong
force-pushed
the
etcd-scaling
branch
from
d879a12 to
b7b3cbd
Compare
g-gaston
reviewed
Dec 5, 2023
ahreehong
force-pushed
the
etcd-scaling
branch
2 times, most recently
from
6c5ac27 to
a4900e8
Compare
g-gaston
reviewed
Dec 20, 2023
ahreehong
force-pushed
the
etcd-scaling
branch
2 times, most recently
from
089e258 to
50dcada
Compare
g-gaston
reviewed
Dec 26, 2023
ahreehong
force-pushed
the
etcd-scaling
branch
from
50dcada to
fec236f
Compare
ahreehong
force-pushed
the
etcd-scaling
branch
from
fec236f to
803edb4
Compare
g-gaston
reviewed
Jan 8, 2024
ahreehong
force-pushed
the
etcd-scaling
branch
from
803edb4 to
12aaaed
Compare
g-gaston
reviewed
Jan 12, 2024
ahreehong
force-pushed
the
etcd-scaling
branch
2 times, most recently
from
ae3b0c8 to
0339b52
Compare
g-gaston
previously approved these changes
Jan 12, 2024
ahreehong
force-pushed
the
etcd-scaling
branch
from
0339b52 to
b75f12b
Compare
g-gaston
previously approved these changes
Jan 12, 2024
ahreehong
force-pushed
the
etcd-scaling
branch
from
b75f12b to
87d8839
Compare
ahreehong
force-pushed
the
etcd-scaling
branch
from
87d8839 to
e7041b0
Compare
abhay-krishna
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Removes webhook blocking etcd replicas from being changed to enable etcd scaling
With testing of etcd scaling, we saw two issues:
Added changes to fix these issues as well.
Additionally, changed condition for max number of etcd replicas from 2x desired replicas to
num all outdated machines + desired replicasto account for edge case if scaling down etcd replicas and also doing an upgradeBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.