Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dismiss invalid files message #6196

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AllanZhengYP
Copy link
Member

@AllanZhengYP AllanZhengYP commented Nov 22, 2024

Description of changes

Add a dismiss button the file validation message.

Screen.Recording.2024-11-21.at.4.05.15.PM.mov

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: d56e3d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AllanZhengYP AllanZhengYP marked this pull request as ready for review November 22, 2024 00:08
@AllanZhengYP AllanZhengYP requested a review from a team as a code owner November 22, 2024 00:08
@AllanZhengYP
Copy link
Member Author

This change is lower priority and can be merged at a later time.

@ashika112
Copy link
Member

Curious: What happens when you dont dismiss it? Does other messages overrides the space?

@AllanZhengYP
Copy link
Member Author

@ashika112 The message will be dismissed as well if users start upload directly. And you are right, any other message will overwrite this validation message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants