Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix transient legacy credential store integ test failure #2983

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

vincetran
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: N/A

Description of changes: From the Android documentation for File.listFiles():

There is no guarantee that the name strings in the resulting array will appear in any specific order; 
they are not, in particular, guaranteed to appear in alphabetical order.

This is important because the test is doing a list comparison where order matters and the test failure shows that:
java.lang.AssertionError: expected:<[2924030b-54c0-48bc-8bff-948418fba949, 7e001127-5f11-41fb-9d10-ab9d6cf41dba]> but was:<[7e001127-5f11-41fb-9d10-ab9d6cf41dba, 2924030b-54c0-48bc-8bff-948418fba949]>

How did you test these changes?
Validated no regression

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested a review from a team as a code owner January 30, 2025 19:20
@vincetran vincetran enabled auto-merge (squash) January 31, 2025 17:50
@vincetran vincetran merged commit 434f9ed into main Jan 31, 2025
3 checks passed
@vincetran vincetran deleted the fix/legacy-credential-store-integ-test branch January 31, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants