Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for collections & MorphOne polymorphic pivot table #523

Merged
merged 11 commits into from
Aug 19, 2024

Conversation

GeorgeFourkas
Copy link
Contributor

I have developed the functionality to support both morphOne relationship on the pivot table.

Also the ability to support collections on the model that has Media.

Also updated the documentation to show the potential users of the package some examples of the usage of those 2 changes.

Note:the code does not include breaking changes.

@awcodes
Copy link
Owner

awcodes commented Aug 12, 2024

Does this still work with the CuratorColumn?

@GeorgeFourkas
Copy link
Contributor Author

GeorgeFourkas commented Aug 12, 2024

Not yet, but i have found a solution and i am currently testing it. It supports Curator Column, on all types of relationships.
I can create a second PR to make it support it

@awcodes awcodes merged commit 8359e49 into awcodes:3.x Aug 19, 2024
4 checks passed
@awcodes
Copy link
Owner

awcodes commented Aug 19, 2024

Sorry, had to revert this. Please see note on #529 and resubmit if you have a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants