Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google wire library #2965

Closed
wants to merge 1 commit into from
Closed

Add google wire library #2965

wants to merge 1 commit into from

Conversation

dsxack
Copy link

@dsxack dsxack commented Feb 18, 2020

Compile-time Dependency Injection for Go

Very good coverage

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added godoc link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR, you're awesome! 👍

@avelino
Copy link
Owner

avelino commented Feb 18, 2020

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body content check:

  • godoc.org: True
  • goreportcard.com: True
  • coverage: True

Copy link
Collaborator

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code coverage is too low to meet our standard, so please increase it.

@dsxack
Copy link
Author

dsxack commented Feb 19, 2020

@panjf2000, I'm sorry. It is google library, and I think it is too hard to increase its coverage. I think the goal does not justify the effort.

But. I start this PR only because I find in list another library with the same name wire for the same Dependency injection section.

Should I close the PR?

@panjf2000
Copy link
Collaborator

I appreciate your proposal but every repo in awesome-go list should be up to standard, even though it is from google.

So I'm closing this PR but still, thanks for your efforts.

@panjf2000 panjf2000 closed this Feb 20, 2020
@dsxack
Copy link
Author

dsxack commented Feb 20, 2020

It is sad. The list of libraries and tools that don't contain popular libraries because of too strict standards.
And contains libraries that non-popular with the same name.
I think this will confuse new developers.
It is non-sense. Thank you.

https://github.com/Fs02/wire - has 25 stars, small documentation, runtime.
https://github.com/google/wire - has 3.2k stars, good documentation, compile-time.

Your strict standards don't do their job. Sometimes coverage 60% is much better than 100% on other library.

@panjf2000

@MihailsKuzmins
Copy link

I would also like to have the Google's wire on the list instead. It would help to get to know libraries which are used in the community most 🤔

@panjf2000 panjf2000 reopened this Sep 5, 2021
@avelino
Copy link
Owner

avelino commented Sep 5, 2021

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: True
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

@panjf2000
Copy link
Collaborator

panjf2000 commented Sep 5, 2021

Reopen this PR to discuss whether we should make exceptions for those repositories with more stars regardless of our standards.
@avelino

@avelino
Copy link
Owner

avelino commented Sep 17, 2021

Reopen this PR to discuss whether we should make exceptions for those repositories with more stars regardless of our standards.

@panjf2000 was discussed in this issue #1446

in short, star is not synonym of quality

@MihailsKuzmins
Copy link

Reopen this PR to discuss whether we should make exceptions for those repositories with more stars regardless of our standards.

@panjf2000 was discussed in this issue #1446

in short, star is not synonym of quality

But is it obvious that Google's wire is used more often than the wire in the current list. In this case it would be more beneficial for developers to get to know the Google's wire. Especially taking into account that their approach is much different than that of Fx or Inject. I doubt that Google would write a library which does not comply with good practices

@dsxack dsxack closed this Sep 20, 2021
@avelino
Copy link
Owner

avelino commented Sep 20, 2021

sad

Screen Shot 2021-09-20 at 17 33 29

@MihailsKuzmins I'm willing to talk to the package maintainers and listen to what they have to say, the communication channel via issue is open for this

@MihailsKuzmins
Copy link

@avelino thank you for not giving up 🙏
I do understand your drive to have only the best packages in the list (it's a good one, no doubt), but I simply want this package to be in the list because of its unique approach to DI (all other packages implement it with "reflect"). So I think other developers might also be interested in it (again repeating myself, sorry...)
Well, it's not that much about starts the project has

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants