Add board support for Arduino MKR WiFi 1010. #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the PR. I would suggest porting this to |
Absolutely, good idea! I'll do it and push an update :) |
| panic-halt = "0.2" | ||
| panic-semihosting = "0.5" | ||
| usbd-serial = "0.1" | ||
| wifi-nina = { git = "https://github.com/Foosvald/wifi-nina", branch = "invert-reset-logic-with-feature", features = ["reset-high"] } |
There was a problem hiding this comment.
Have you managed to get your changes upstreamed? I don't really like depending on someone's personal branch. That feels very hacky. Plus, I don't think you can even publish to crates.io if you have a Git dependency.
|
@Foosvald, I think this looks good. The Git dependency is the only show stopper. Have you tested all your examples? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds initial board support for the Arduino MKR WiFi 1010 board.
(This is my first PR here and I'm also pretty new to both embedded and Rust, so I hope I've done everything correctly. And I would be happy to fix anything according to your feedback!)
The wifi_nina library hasn't been updated in a while so I currently use my fork of it until (or if) dflemstr/wifi-nina#6 is merged upstream.
.
Checklist
CHANGELOG.mdfor the BSP or HAL updatedIf Adding a new Board
crates.json