Make use of PHP 7 features #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds scalar type declarations and return type declarations. Increases the minimum version of PHP to 7.0.0.
|
Does anybody know the current state of PHP 7 features implemented in HHVM? Do we care about HHVM? |
HHVM doesn't expose itself to as PHP 7 to composer table flips when you try to run composer install on it. Didn't go any further and pretty much dropping HHVM from my PHP 7 only package over the last months because of that. No idea what PHP 7 features they would support |
|
Can you please PR the fixes separately (like detatch => detach, $time => $msDelay etc.)? |
|
Closing as of #2 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scalar type declarations and return type declarations. Increases the minimum version of PHP to 7.0.0.
We can discuss whether we make the error handler an interface now, as we have anonymous classes.
Relates to #2.