Skip to content

Commit

Permalink
Eugh. Create the sepwin before the recwin
Browse files Browse the repository at this point in the history
The sepwin depends on a value computed by the recwin's draw handler.
This is kinda nasty...
  • Loading branch information
davidben committed Jun 12, 2010
1 parent 358eeae commit 4eee948
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions doc/owl-window.txt
Original file line number Diff line number Diff line change
Expand Up @@ -174,3 +174,8 @@ Known issues and notes
ids. This is somewhat a side effect of us not using GObject
everywhere; the signals can automatically disconnect in the right
contexts if we do.

- The sepbar depends on a value computed while the mainwin is drawn,
so we currently ensure the windows are created in the right order
for the repaints to occur correctly. This is rather poor and should
be refactored later.
4 changes: 3 additions & 1 deletion mainpanel.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ void owl_mainpanel_init(owl_mainpanel *mp)
{
/* Create windows */
mp->panel = owl_window_new(NULL);
mp->recwin = owl_window_new(mp->panel);
/* HACK for now: the sepwin must be drawn /after/ the recwin for
* lastdisplayed to work */
mp->sepwin = owl_window_new(mp->panel);
mp->recwin = owl_window_new(mp->panel);
mp->msgwin = owl_window_new(mp->panel);
mp->typwin = owl_window_new(mp->panel);

Expand Down

0 comments on commit 4eee948

Please sign in to comment.