Styleguide for PR #7 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Demo app is now agent-application - added methods to toggle Popover, updated Demo - added AXStatusItemPopupDelegate - updated Project preferences (suggested by Xcode) - Popup is now FirstResponder when open, updated Demo
Trying to improve behaviour. Two problems are left: - When opening Mission Control popover stays on top - Sometimes when opening popover background window of the same program get activated
for hiding Popover when selecting another MenuItem
|
I should add that I really put many efforts in fixing this thing with Mission Control. But there is no single indicator that Mission Control is opened. No notification, no delegate. I even tried it with Quartz Event Taps (suggested here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, finally it's there :D
I hope I'm now conform to your style guide. Relating to my last pull request I made some additional changes, mainly improving the window handling.
Now there are the problem with Mission Control left (I don't now why I thought I fixed it, maybe it was on Mavericks, I'm now on Yosemite) and a minor issue (namely a window of the app get focused when opening popover).
I also added the Transiency monitor for hiding the popover when clicking on other menu items. I didn't add the dummy menu (it had no effect for me) and the content size API (I use autolayout). You can merge them back.