Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Ansible lint reqs #5052

Merged
merged 19 commits into from
Feb 21, 2025
Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 17, 2025

Change Summary

Change collections.yml to requirements.yml to make ansible-lint happier.

Component(s) name

ci

Proposed changes

  • Rename file
  • Add symlink until 6.0.0
  • Adjust places where collections.yml is used (molecule, vrify requirements)
  • Add to release notes
  • Fix CI

How to test

CI passes

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5052
# Activate the virtual environment
source test-avd-pr-5052/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@ansible-lint-reqs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,ansible-lint-reqs --force
# Optional: Install AVD examples
cd test-avd-pr-5052
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR labels Feb 17, 2025
@gmuloc gmuloc marked this pull request as ready for review February 18, 2025 13:00
@gmuloc gmuloc requested review from a team as code owners February 18, 2025 13:00
@ClausHolbechArista ClausHolbechArista requested a review from a team February 18, 2025 14:16
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Feb 18, 2025
@gmuloc gmuloc added this to the v5.3.0-dev1 milestone Feb 18, 2025
@ClausHolbechArista ClausHolbechArista merged commit 6a995fe into aristanetworks:devel Feb 21, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: CI state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants