-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Ansible lint reqs #5052
Merged
ClausHolbechArista
merged 19 commits into
aristanetworks:devel
from
gmuloc:ansible-lint-reqs
Feb 21, 2025
Merged
CI: Ansible lint reqs #5052
ClausHolbechArista
merged 19 commits into
aristanetworks:devel
from
gmuloc:ansible-lint-reqs
Feb 21, 2025
+95
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5052
# Activate the virtual environment
source test-avd-pr-5052/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@ansible-lint-reqs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,ansible-lint-reqs --force
# Optional: Install AVD examples
cd test-avd-pr-5052
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
requested changes
Feb 17, 2025
fb2f209
to
b731954
Compare
b731954
to
a352e57
Compare
ClausHolbechArista
approved these changes
Feb 18, 2025
|
ClausHolbechArista
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: CI
state: CI Updated
CI scenario have been updated in the PR
type: code quality
CI and development toolset
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Change collections.yml to requirements.yml to make ansible-lint happier.
Component(s) name
ci
Proposed changes
How to test
CI passes
Checklist
Repository Checklist