Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add social media brand colors pack (Closes #471) #520

Merged
merged 9 commits into from
Oct 8, 2024
Merged

Add social media brand colors pack (Closes #471) #520

merged 9 commits into from
Oct 8, 2024

Conversation

aspizu
Copy link
Contributor

@aspizu aspizu commented Oct 3, 2024

No description provided.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Oct 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

argyleink
argyleink requested changes Oct 3, 2024
View reviewed changes
Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great!
missing 1 entry in the exports of package.json, then that wraps up the props work

are you open to adding a section to the docsite that shows all the colors?

package.json Outdated Show resolved Hide resolved
src/props.brand.js Outdated Show resolved Hide resolved
@aspizu aspizu marked this pull request as ready for review October 3, 2024 21:19
argyleink
argyleink requested changes Oct 3, 2024
View reviewed changes
docsite/js/brand-colors.js Outdated Show resolved Hide resolved
docsite/index.js Outdated Show resolved Hide resolved
docsite/index.html Show resolved Hide resolved
argyleink
argyleink approved these changes Oct 8, 2024
View reviewed changes
Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for pushing the prerendered markup and waiting for me while I was on bereavement.

@argyleink argyleink merged commit 917d952 into argyleink:main Oct 8, 2024
2 checks passed
@argyleink
Copy link
Owner

available in v1.7.7, site update coming soon

@aspizu
Copy link
Contributor Author

aspizu commented Oct 9, 2024

I would appreciate it if you could add the hacktoberfest-accepted label to my PR.

@aspizu
Copy link
Contributor Author

aspizu commented Oct 9, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argyleink argyleink argyleink approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspizu @argyleink