Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update all documentation links #8045

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: update all documentation links #8045

wants to merge 7 commits into from

Conversation

itaysk
Copy link
Contributor

@itaysk itaysk commented Dec 4, 2024 •
edited
Loading

Description

update all links from aquasecurity.github.io/trivy to trivy.dev
links are found in:

  • documentation
  • code comments
  • SPDX SBOM

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Feb 3, 2025
@itaysk itaysk marked this pull request as ready for review February 10, 2025 14:21
@itaysk itaysk removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Feb 10, 2025
@itaysk
Copy link
Contributor Author

itaysk commented Feb 10, 2025

besides documentation links, do you see any issue with updading the sbom namespace?

DmitriyLewen
DmitriyLewen reviewed Feb 11, 2025
View reviewed changes
docs/docs/configuration/cache.md Outdated Show resolved Hide resolved
docs/docs/configuration/filtering.md Show resolved Hide resolved
docs/docs/supply-chain/sbom.md Outdated Show resolved Hide resolved
@DmitriyLewen
Copy link
Contributor

do you see any issue with updading the sbom namespace?

I think this change is acceptable.
I think DocumentNamespace is more of a reference information and users don't parse this field automatically (programmatically). So this shouldn't be a problem.

DmitriyLewen
DmitriyLewen reviewed Feb 12, 2025
View reviewed changes
pkg/version/doc/doc.go Outdated Show resolved Hide resolved
docs/docs/supply-chain/sbom.md Show resolved Hide resolved
DmitriyLewen
DmitriyLewen approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@afdesk afdesk Awaiting requested review from afdesk afdesk is a code owner

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itaysk @DmitriyLewen @simar7