first commit was pushed related to update the trivy version #52
Conversation
|
|
|
hi @calsoftfaizal813 - thanks for the PR. A few comments:
|
| context.subscriptions.push(vscode.commands.registerCommand( | ||
| "trivy-vulnerability-scanner.scan", | ||
| () => { | ||
| const trivyScanCmd = "trivy --quiet filesystem --security-checks config,vuln --exit-code=10"; | ||
| var scanResult = runCommand(trivyScanCmd, projectRootPath.toString()); | ||
| context.subscriptions.push( | ||
| vscode.commands.registerCommand("trivy-vulnerability-scanner.scan", () => { | ||
| const trivyScanCmd = | ||
| "trivy --quiet filesystem --security-checks config,vuln --exit-code=10"; | ||
| let scanResult = runCommand(trivyScanCmd, projectRootPath.toString()); |
There was a problem hiding this comment.
Please update the commands as per the log output from the extension
2024-10-28T23:17:33-06:00 WARN '--security-checks' is deprecated. Use '--scanners' instead.
2024-10-28T23:17:33-06:00 WARN '--scanners config' is deprecated. Use '--scanners misconfig' instead. See https://github.com/aquasecurity/trivy/discussions/5586 for the detail.There was a problem hiding this comment.
when I replaced the '--security-checks' with the '--scanners' and '--scanners config' with '--scanners misconfig' then I got this error
There was a problem hiding this comment.
Did you check the logs to see what's causing the error?
There was a problem hiding this comment.
Hi @simar7, Could you please help me with this one where I can see the logs for this error, I tried to find but was not able to find the logs in my local environment
There was a problem hiding this comment.
A lot of these changes are style based, are you running any linter to do so? It makes it hard to review this PR so can we update the linter changes in a separate PR? They are not really necessary for this PR.
There was a problem hiding this comment.
I have default installed eslint and prettier extensions to format the javascript and typescript code that's why we have removed the extra white spaces and variable declaration changes, please let me know if it is not really required for now so I can revert the changes for this file?
There was a problem hiding this comment.
As we mentioned earlier, we're just looking to upgrade this extension to support the latest version of Trivy. Any other changes should be done in a separate PR as they aren't related to that.
There was a problem hiding this comment.
See my comment on style/lint here https://github.com/aquasecurity/trivy-vscode-extension/pull/52/files#r1820103613
Hi Simarpreet Singh. |
The project already contains two test targets, one is for running the extension and the other for tests. https://github.com/aquasecurity/trivy-vscode-extension/blob/master/src/test/suite/extension.test.ts You can read more on how to run the test target here: https://code.visualstudio.com/api/working-with-extensions/testing-extension |
I ran trivy scanning for the test project "Trivy-ci-test" and updated the trivy version.
there are three file changes included in this commit:
extension.ts
trivy_wrapper.ts
package-lock.json
here are the screenshots of the scanning results:
