Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of PR #2300 #2356

Merged
merged 20 commits into from
Dec 29, 2023
Merged

Update of PR #2300 #2356

merged 20 commits into from
Dec 29, 2023

Conversation

tenthe
Copy link
Contributor

@tenthe tenthe commented Dec 20, 2023

Purpose

This PR is an update of #2300. I could not push my changes to the other PR.
Therefore I created a new one.

I had to merge the new HTTP API into the branch. @muyangye can you please check if this is correct?

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code ui Anything that affects the UI backend Everything that is related to the StreamPipes backend testing Relates to any kind of test (unit test, integration, or E2E test). labels Dec 20, 2023
@muyangye
Copy link
Member

muyangye commented Dec 21, 2023

@tenthe Thanks a lot for merging🙏.

Is there any reason to switch from JAX-RS to Spring MVC? I copied the code to local and was not able to compile it because endpoints in PipelineElementFile.java expect a return of type ResponseEntity which is part of Spring MVC whereas the actual return is of type Response which is part of JAX-RS. Other than that I spot no issues.

@tenthe
Copy link
Contributor Author

tenthe commented Dec 23, 2023

Hey @muyangye,
thanks for trying it out.

What exactly didn't work for you?
I just tried to upload two files with the same name and I was able to change the name of the second file.
My last commit only fixes some linting errors.

The change from JAX-RS to Spring MVC was made to harmonize our code base, see #2276.
If the change causes problems in your development setup just let me know and we can try to solve it together.

@muyangye
Copy link
Member

Hey @muyangye, thanks for trying it out.

What exactly didn't work for you? I just tried to upload two files with the same name and I was able to change the name of the second file. My last commit only fixes some linting errors.

The change from JAX-RS to Spring MVC was made to harmonize our code base, see #2276. If the change causes problems in your development setup just let me know and we can try to solve it together.

@tenthe Thanks for pointing out the harmonization PR. I wasn't able to do git pull or git push so I didn't get the latest change brought by #2276. After manually downloading the dev branch to local I was able to compile and everything works perfectly. Let's merge this PR and I'll continue the work on #2181 once I return to USA since I have network issue with git right now.

@tenthe tenthe merged commit 4495b46 into dev Dec 29, 2023
18 checks passed
@tenthe tenthe deleted the fork/dev branch December 29, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Everything that is related to the StreamPipes backend dependencies Pull requests that update a dependency file java Pull requests that update Java code testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants