-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of PR #2300 #2356
Update of PR #2300 #2356
Conversation
…service/core/migrations/v095/DuplicateFilesRenameMigration.java Co-authored-by: Tim <[email protected]>
…nt.html Co-authored-by: Tim <[email protected]>
…l/PipelineElementFile.java Co-authored-by: Tim <[email protected]>
…l/PipelineElementFile.java Co-authored-by: Tim <[email protected]>
…ginal-file-name-v2' into fork/dev
@tenthe Thanks a lot for merging🙏. Is there any reason to switch from JAX-RS to Spring MVC? I copied the code to local and was not able to compile it because endpoints in |
Hey @muyangye, What exactly didn't work for you? The change from JAX-RS to Spring MVC was made to harmonize our code base, see #2276. |
@tenthe Thanks for pointing out the harmonization PR. I wasn't able to do git pull or git push so I didn't get the latest change brought by #2276. After manually downloading the dev branch to local I was able to compile and everything works perfectly. Let's merge this PR and I'll continue the work on #2181 once I return to USA since I have network issue with git right now. |
Purpose
This PR is an update of #2300. I could not push my changes to the other PR.
Therefore I created a new one.
I had to merge the new HTTP API into the branch. @muyangye can you please check if this is correct?
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no