Make upsert compaction task more robust to crc mismatch #13489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibrewalpratik17
force-pushed
the
fix_upsert_compaction_schema_reload
branch
from
4ee039f to
1fc8d3b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13489 +/- ##
============================================
+ Coverage 61.75% 62.11% +0.35%
+ Complexity 207 198 -9
============================================
Files 2436 2558 +122
Lines 133233 140960 +7727
Branches 20636 21868 +1232
============================================
+ Hits 82274 87553 +5279
- Misses 44911 46793 +1882
- Partials 6048 6614 +566
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tibrewalpratik17
changed the title
tibrewalpratik17
force-pushed
the
fix_upsert_compaction_schema_reload
branch
from
1b76d1c to
f2059b5
Compare
tibrewalpratik17
changed the title
klsince
reviewed
Jul 1, 2024
| List<ValidDocIdsMetadataInfo> presentValidDocIdsMetadataInfo = | ||
| validDocIdsMetadataInfos.computeIfAbsent(segmentName, k -> new ArrayList<>()); | ||
| presentValidDocIdsMetadataInfo.add(validDocIdsMetadataInfo); | ||
| validDocIdsMetadataInfos.put(segmentName, presentValidDocIdsMetadataInfo); |
There was a problem hiding this comment.
L289-L292 can be inlined as map.computeIfAbsent().add()
There was a problem hiding this comment.
Done! I thought of using addAll as well but then i will have to do if(!empty) then get(0).getSegmentName.
So kept the iterative loop here.
klsince
reviewed
Jul 1, 2024
...java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskExecutor.java
Outdated
Show resolved
Hide resolved
klsince
reviewed
Jul 1, 2024
...ava/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java
Outdated
Show resolved
Hide resolved
klsince
reviewed
Jul 1, 2024
...t-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java
Outdated
Show resolved
Hide resolved
klsince
reviewed
Jul 2, 2024
...minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java
Outdated
Show resolved
Hide resolved
klsince
reviewed
Jul 8, 2024
...minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java
Show resolved
Hide resolved
...java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskExecutor.java
Outdated
Show resolved
Hide resolved
tibrewalpratik17
force-pushed
the
fix_upsert_compaction_schema_reload
branch
from
6338fa2 to
0115cac
Compare
klsince
approved these changes
Jul 10, 2024
...minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java
Outdated
Show resolved
Hide resolved
...minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing multiple fixes / enhancements in this patch together for faster reviews.
Enhancement 1
Solves Scenario 1 of #13491 where Segment ZK Metadata CRC = Segment CRC deepstore != ValidDocID Bitmap CRC was happening.
The change here is to iterate through all peer servers and see if we can find atleast 1 host with matching CRCs and proceed with the task execution. Assumption is that we have one host which was the leader in updating ZK and uploading to deepstore as well.
We also fail the task-execution if we don't find any such host instead of silently skipping and succeeding the task which we were doing previously.
I tried this fix out for one of our tables and the tasks which were blocked initially due to this issue, it successfully executed compaction after this change and we saw a drop in the row-count and size.
Enhancement 2
Solves #13492. The controller fetches validDocIDBitmap from one of the replica servers and compares the CRC in the response against the segment ZK metadata CRC. If they don't match, the segment is not considered for compaction.
The fix is similar to the previous solution. We already retrieve all the bitmaps from all servers. Instead of randomly considering just one, we now iterate through all the bitmaps for each segment. If any of them match the ZK CRC, the segment is then considered for compaction.
I deployed this fix for one of our tables, which unblocked many segments for compaction. Attached is a screenshot showing the drop in rows.
