GH-3115-Fix int96 read issue in complex type #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fokko @gszadovszky @wgtmac Can you please take a look when you have a chance? |
gszadovszky
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Thanks for working on this, @pratyush-sharma-2025. I think you can simplify your code greatly. See my comment in the code.
parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java
Outdated
Show resolved
Hide resolved
gszadovszky
requested changes
Jan 28, 2025
parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-avro/src/main/java/org/apache/parquet/avro/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
gszadovszky
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Thanks, @pratyush-sharma-2025. Everything looks good.
Let me wait for an additional day before committing so others have the chance to object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There is an issue with reading of INT96 timestamp when they are present in a complex data type such as List.
It gives the following error -
Exception in thread "main" java.lang.IllegalArgumentException: INT96 is deprecated. As interim enable READ_INT96_AS_FIXED flag to read as byte array.More details are present here.
What changes are included in this PR?
AvroSchemaConverter(boolean assumeRepeatedIsListElement, ParquetConfiguration conf)while checking if the given type is element type of a list inAvroRecordConverter#isElementType()Are these changes tested?
Added a new test case
TestArrayCompatibility#testIsElementTypeInt96Element()Are there any user-facing changes?
No.
Closes #3115