Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-11700. Use ozone-runner from GitHub in ozone image build #33

Merged
merged 1 commit into from
Nov 14, 2024
Merged

HDDS-11700. Use ozone-runner from GitHub in ozone image build #33

merged 1 commit into from
Nov 14, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

When building apache/ozone Docker image in GitHub workflow, pull ozone-runner from GitHub Container Registry instead of Docker Hub.

https://issues.apache.org/jira/browse/HDDS-11700

How was this patch tested?

Verified base image in CI build:

#4 [linux/amd64 internal] load metadata for ghcr.io/apache/ozone-runner:20241108-jdk17-1
#4 DONE 1.2s

#2 [linux/arm64 internal] load metadata for ghcr.io/apache/ozone-runner:20241108-jdk17-1
#2 DONE 1.2s

https://github.com/adoroszlai/ozone-docker/actions/runs/11833939687/job/32973630196#step:7:220

Verified base image in local build without setting OZONE_RUNNER_IMAGE:

 => [internal] load metadata for docker.io/apache/ozone-runner:20241108-jdk17-1

@adoroszlai adoroszlai self-assigned this Nov 14, 2024
@adoroszlai adoroszlai changed the base branch from 0.3.0 to latest November 14, 2024 09:14
@adoroszlai adoroszlai requested a review from smengcl November 14, 2024 09:17
smengcl
smengcl approved these changes Nov 14, 2024
View reviewed changes
Copy link

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks @adoroszlai

@adoroszlai adoroszlai merged commit d1bb3b6 into apache:latest Nov 14, 2024
1 check passed
@adoroszlai
Copy link
Contributor Author

Thanks @smengcl for the review.

@adoroszlai adoroszlai deleted the HDDS-11700 branch November 14, 2024 10:07
adoroszlai added a commit that referenced this pull request Nov 21, 2024
@adoroszlai
HDDS-11700. Use ozone-runner from GitHub in ozone image build (#33)
5a9fc1b 
(cherry picked from commit d1bb3b6)
adoroszlai added a commit to adoroszlai/ozone-docker that referenced this pull request Nov 21, 2024
@adoroszlai
HDDS-11700. Use ozone-runner from GitHub in ozone image build (apache#33
944803b 
)

(cherry picked from commit d1bb3b6)
adoroszlai added a commit to adoroszlai/ozone-docker that referenced this pull request Nov 21, 2024
@adoroszlai
HDDS-11700. Use ozone-runner from GitHub in ozone image build (apache#33
222e843 
)
adoroszlai added a commit to adoroszlai/ozone-docker that referenced this pull request Nov 21, 2024
@adoroszlai
HDDS-11700. Use ozone-runner from GitHub in ozone image build (apache#33
c9828e4 
)
adoroszlai added a commit to adoroszlai/ozone-docker that referenced this pull request Nov 21, 2024
@adoroszlai
HDDS-11700. Use ozone-runner from GitHub in ozone image build (apache#33
1a52c52 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smengcl smengcl smengcl approved these changes

Assignees

@adoroszlai adoroszlai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adoroszlai @smengcl