Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8540] Add cache to API requests #2051

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 17, 2025

JIRA issue: MNG-8540

Related to MNG-8520.
Adding caching inside DefaultPluginDependenciesResolver could be done
by using this PR and rewriting the class to leverage the new API.

  • Add equals/hashcode to all requests
  • Add session-wide cache
  • Add cache to other services

@gnodet gnodet changed the title API cache [MNG-8540] Add cache to API requests Jan 24, 2025
@gnodet gnodet marked this pull request as ready for review January 24, 2025 22:27
@gnodet gnodet force-pushed the api-cache branch 7 times, most recently from aa5cfd7 to 9e3b1e0 Compare January 31, 2025 08:07
@gnodet gnodet marked this pull request as draft January 31, 2025 16:18
@gnodet
Copy link
Contributor Author

gnodet commented Jan 31, 2025

Still need to be cleaned a bit

  • ModelFactory is not used anymore and need to be removed
  • make the RequestCache actually pluggable (the instantiation is hardcoded for now)

@gnodet gnodet force-pushed the api-cache branch 6 times, most recently from 0a7b894 to 247ba6b Compare February 3, 2025 07:51
@gnodet gnodet added this to the 4.0.0-rc-4 milestone Feb 3, 2025
@gnodet gnodet force-pushed the api-cache branch 3 times, most recently from 9d44eaf to cb1b1e0 Compare February 5, 2025 14:49
@gnodet gnodet marked this pull request as ready for review February 5, 2025 17:20
@gnodet gnodet modified the milestones: 4.0.0-rc-4, 4.0.0-rc-3 Feb 5, 2025
@gnodet gnodet merged commit 6aa86c5 into apache:master Feb 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants