fix:ForEach Controller Start index for loop not using variable #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
reviewed
Nov 26, 2024
Comment on lines
201
to
203
| if (loopCount < getStartIndex()) { | ||
| loopCount = getStartIndex(); | ||
| } |
There was a problem hiding this comment.
Could you add a test case to cover the change?
It looks suspicious to call getStartIndex() twice as it might produce different results on every call.
There was a problem hiding this comment.
Do you mean you want me to add a unit test about the change? I have only verified that this change can solve the problem. #6180
There was a problem hiding this comment.
Do you mean you want me to add a unit test about the change?
Yeah. We need to add tests to prevent accidental regressions.
Here's a sample:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6108