Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2241] improvement(server): Introduce storage flush operation timeout cancel to avoid disk hang #2247

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

zuston
Copy link
Member

@zuston zuston commented Nov 12, 2024

What changes were proposed in this pull request?

Introduce storage flush operation timeout cancel to avoid disk hang

Why are the changes needed?

For #2241

Does this PR introduce any user-facing change?

Yes.
rss.server.storage.flushOptionTimeoutSec is introduced, the default value = -1 means this timeout cancel will not be activated by default

How was this patch tested?

unit tests and existing tests.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (10c02cd) to head (130b3bb).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...pache/uniffle/server/DefaultFlushEventHandler.java 30.76% 8 Missing and 1 partial ⚠️
.../uniffle/common/future/CompletableFutureUtils.java 80.95% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2247      +/-   ##
============================================
+ Coverage     52.15%   52.43%   +0.27%     
+ Complexity     3517     2959     -558     
============================================
  Files           550      467      -83     
  Lines         31672    22185    -9487     
  Branches       2707     2033     -674     
============================================
- Hits          16518    11632    -4886     
+ Misses        14098     9815    -4283     
+ Partials       1056      738     -318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 12, 2024

Test Results

 2 956 files  +15   2 956 suites  +15   6h 10m 50s ⏱️ - 6m 29s
 1 092 tests + 1   1 090 ✅ + 1   2 💤 ±0  0 ❌ ±0 
13 685 runs  +15  13 655 ✅ +15  30 💤 ±0  0 ❌ ±0 

Results for commit 92ae079. ± Comparison against base commit 4db95c3.

♻️ This comment has been updated with latest results.

@zuston zuston requested a review from jerqi November 12, 2024 05:37
@zuston zuston merged commit 4eebbd4 into apache:master Nov 14, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants