Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2241] feat(server): Introduce option to mark server unhealthy once any storage corrupted #2245

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

zuston
Copy link
Member

@zuston zuston commented Nov 11, 2024

What changes were proposed in this pull request?

Introduce option to mark server unhealthy once any storage corrupted.

Why are the changes needed?

For: #2241
This feature is to reduce the impact while the local directories are corrupted.

Does this PR introduce any user-facing change?

Yes.

rss.server.health.markUnhealthyOnceStorageCorruption is introduced, the default value is false that will not activate this feature by default.

How was this patch tested?

Existing unit tests.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.86%. Comparing base (10c02cd) to head (b8599f5).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...org/apache/uniffle/server/LocalStorageChecker.java 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2245      +/-   ##
============================================
+ Coverage     52.15%   52.86%   +0.71%     
- Complexity     3517     3546      +29     
============================================
  Files           550      531      -19     
  Lines         31672    29272    -2400     
  Branches       2707     2721      +14     
============================================
- Hits          16518    15476    -1042     
+ Misses        14098    12810    -1288     
+ Partials       1056      986      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

 2 941 files  + 6   2 941 suites  +6   6h 10m 46s ⏱️ + 8m 53s
 1 091 tests ± 0   1 089 ✅ + 2   2 💤 ±0  0 ❌  - 1 
13 670 runs  +12  13 640 ✅ +14  30 💤 ±0  0 ❌  - 1 

Results for commit b8599f5. ± Comparison against base commit 77c5c61.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zuston Thanks for this fix, LGTM.

@zuston zuston merged commit 56f4994 into apache:master Nov 11, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants