[MINOR] feat(server,dashboard,coordinator): Report configured metrics of server to coordinator and display to dashboard #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maobaolong
changed the title
maobaolong
changed the title
maobaolong
force-pushed
the
displayAppPartnum
branch
from
2575786
to
b1ff165
Compare
maobaolong
changed the title
maobaolong
changed the title
|
@zuston Would you like to take a look at this PR? Thanks. |
zuston
reviewed
Nov 14, 2024
| @@ -303,6 +303,7 @@ message ShuffleServerHeartBeatRequest { | |||
| optional string gitCommitId = 23; | |||
| optional int64 startTimeMs = 24; | |||
| repeated ApplicationInfo applicationInfo = 25; | |||
| map<string, string> displayMetrics = 30; | |||
There was a problem hiding this comment.
why not as the sequence number of 26?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Report configured metrics of server to coordinator and display to dashboard
Why are the changes needed?
With this feature, it can be extensible for displaying server state by dashboard.
In the beginning, we only need to display the app number in the dashboard, after a few days, we want to add partition with node in to dashboard, maybe no more days later, we need another value displayed in to dashboard.
So it is not extensible if we add it one by one, this is why I invent this feature, it can be easy to let user config the metrics what they think it is necessary and should be displayed in the dashboard.
Does this PR introduce any user-facing change?
How was this patch tested?
Test Locally.