-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1401] improvement(dashboard): Fixed distorted page display due to excessively long property values #2009
Conversation
@rickyma @maobaolong @xianjingfeng PATL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others lgtm.
@@ -127,7 +127,7 @@ Mock.mock(/\/coordinator\/conf/, 'get', { | |||
}, | |||
{ | |||
argumentKey: 'java.home', | |||
argumentValue: '/home/hadoop/jdk-11.0.2' | |||
argumentValue: '/root/jdk-11.0.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these changes? It's automatically generated in your environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a mistake in the substitution.fixed.
… long and the page display is distorted.
Understood, I may use the original version here, it is OK this PR does not affect, sometimes the path is too long will not look good, use this will not affect the beauty. |
can I search a text within a long value after this PR? |
This was a very good suggestion and I decided to add a search window, which is done. |
… long and the page display is distorted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yl09099 This PR looks pretty good, thanks for your contribution!
Merged. Thanks @yl09099 @advancedxy @maobaolong |
…e to excessively long property values (apache#2009) ### What changes were proposed in this pull request? Fixed the property value is too long and the page display is distorted. 1. If the content of the cell is too long, use ellipses to replace the excess. 2. Provide bubbles to show everything. ![image](https://github.com/user-attachments/assets/83d4f962-03b7-4c15-82fd-070e7e875c8a) ![image](https://github.com/user-attachments/assets/a9c4add7-e461-4332-bbba-c8ca9c9d5740) ### Why are the changes needed? Fix: apache#1401 ### Does this PR introduce _any_ user-facing change? Yes. ### How was this patch tested? Page display. (cherry picked from commit 41389df)
What changes were proposed in this pull request?
Fixed the property value is too long and the page display is distorted.
Why are the changes needed?
Fix: #1401
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Page display.