IGNITE-24150 Ability to have different prefixes for exceptions #4991
Conversation
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroup.java
Outdated
Show resolved
Hide resolved
| /** Group name. */ | ||
| private final String groupName; | ||
|
|
||
| /** Group code. */ | ||
| private final short groupCode; | ||
|
|
||
| /** Additional prefix that is used in a human-readable format of error messages. */ | ||
| private final String errorPrefix; |
There was a problem hiding this comment.
Hmm, I'm a little confused by the name. Perhaps, it would be nice to change to groupNamePrefix, or vendorSpecificPrefix etc. What do you think?
There was a problem hiding this comment.
If we honestly it's not so important and all variants reflect nature of the field but from different perspective
| * @param message Original message. | ||
| * @return New error message with predefined prefix. | ||
| */ | ||
| static String errorMessage(String errorPrefix, UUID traceId, String groupName, int code, String message) { |
There was a problem hiding this comment.
Honestly, I don't like this idea. I mean creating a new class with duplicating code looks odd to me.
There was a problem hiding this comment.
#4991 (comment)
We have two chairs here -introduce in public API method which not required for user and can be used wrong or make a small duplication.
|
|
||
| /** | ||
| * Defines error groups and its errors. | ||
| */ | ||
| @SuppressWarnings("PublicInnerClass") | ||
| public class ErrorGroups { | ||
| /** Additional prefix that is used in a human-readable format of ignite errors. */ | ||
| public static final String IGNITE_ERR_PREFIX = "IGN"; |
There was a problem hiding this comment.
Perhaps, the following code should be updated as well
https://issues.apache.org/jira/browse/IGNITE-24150