Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][HUDI-8368] Remove unused logic of rollback log block creation in BaseRollbackHelper #12728

Closed
wants to merge 1 commit into from

Conversation

ktblsva
Copy link
Contributor

@ktblsva ktblsva commented Jan 29, 2025

Change Logs

Remove unused logic

Impact

Clean code

Risk level (write none, low medium or high below)

NA

Documentation Update

None

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Jan 29, 2025
@ktblsva
Copy link
Contributor Author

ktblsva commented Jan 29, 2025

@yihua hello! i have some questions. we still have some code for table version < 8 , where we set value to logBlocksToBeDeleted, e.g. MarkerBaserRollbackStrategy#createRollbackRequestForAppend. do we need to clean it too?

@yihua
Copy link
Contributor

yihua commented Jan 29, 2025

@yihua hello! i have some questions. we still have some code for table version < 8 , where we set value to logBlocksToBeDeleted, e.g. MarkerBaserRollbackStrategy#createRollbackRequestForAppend. do we need to clean it too?

We still need the rollback logic for log appends in the backwards compatible writer in Hudi 1.0, i.e., when using Hudi 1.0 to write with table version 6 which appends rollback log block for log files.

@ktblsva ktblsva closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants