Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HudiFileGroupReader with consolidated APIs to read records #164

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

xushiyan
Copy link
Member

Description

  • Add FileGroupReader with APIs to read file slices
  • Migrate existing APIs to use FileGroupReader

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added feature python Related to Python codebase rust Related to Rust codebase labels Oct 12, 2024
@xushiyan xushiyan added this to the release-0.2.0 milestone Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.81%. Comparing base (2ef9557) to head (72ca4d7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/file_group/reader.rs 92.85% 1 Missing ⚠️
crates/core/src/table/mod.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   89.16%   89.81%   +0.65%     
==========================================
  Files          16       17       +1     
  Lines         877      884       +7     
==========================================
+ Hits          782      794      +12     
+ Misses         95       90       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan marked this pull request as ready for review October 12, 2024 10:39
@xushiyan xushiyan merged commit d5f42f6 into apache:main Oct 12, 2024
9 checks passed
@xushiyan xushiyan deleted the add-fg-reader branch October 12, 2024 11:02
@xushiyan xushiyan mentioned this pull request Nov 22, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature python Related to Python codebase rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant