-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TableBuilder
API for creating Table
instances
#163
Conversation
@xushiyan please let me know if this is a direction you're fine with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some refactoring around this. can you check out #161 first, and adjust this PR accordingly please?
@kazdy i'm cutting release branch within 1 day. do you think you can update this soon? |
yes, I'll give it a try |
… empty hudi_options
… empty hudi_options
a52fd56
to
f548a81
Compare
TableBuilder
to handle storage_options explicitly
@kazdy I'll push some fixes and then get this landed for release |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 89.81% 90.35% +0.53%
==========================================
Files 17 19 +2
Lines 884 933 +49
==========================================
+ Hits 794 843 +49
Misses 90 90 ☔ View full report in Codecov by Sentry. |
TableBuilder
to handle storage_options explicitlyTableBuilder
API for passing options
TableBuilder
API for passing optionsTableBuilder
API for creating Table
instances
Description
Add
TableBuilder
to handle Table construction.Allow to explicitly set hudi_options and storage_options via builder in rust or via python bindings when creating new Table instance.
similarly for python
resolves: #139
How are the changes test-covered