Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] translate explode json array double #1932

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[doc] translate explode json array double #1932

wants to merge 8 commits into from

Conversation

CosmosNi
Copy link

@CosmosNi CosmosNi commented Jan 24, 2025 •
edited
Loading

Versions

  • 2.1

Languages

  • Chinese

Docs Checklist

  • Checked by AI
  • Test Cases Built

@CosmosNi
Copy link
Author

@morrySnow PTAL

@CosmosNi
Copy link
Author

@morrySnow PTAL

@CosmosNi CosmosNi requested a review from morrySnow January 24, 2025 06:40
@CosmosNi
Copy link
Author

@KassieZ PTAL

morrySnow
morrySnow reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 所有章节标题都要改成中文
  2. 语法章节：函数名大写；参数需要用尖括号包裹
  3. 缺少参数章节
  4. 示例章节：去掉 prompt，即 mysql>; 查询语句和结果应放到两个 code block 中，查询语句使用sql格式，结果使用text格式

...ntent-docs/version-2.1/sql-manual/sql-functions/table-functions/explode-json-array-double.md Outdated Show resolved Hide resolved
@CosmosNi
Copy link
Author

CosmosNi commented Feb 5, 2025

  1. 所有章节标题都要改成中文
  2. 语法章节：函数名大写；参数需要用尖括号包裹
  3. 缺少参数章节
  4. 示例章节：去掉 prompt，即 mysql>; 查询语句和结果应放到两个 code block 中，查询语句使用sql格式，结果使用text格式

hello，参考其他的文件，2，3，4是否应该和其他文件格式保持一致，或者有参考的文件么

@CosmosNi CosmosNi requested a review from morrySnow February 5, 2025 14:51
@morrySnow
Copy link
Contributor

  1. 所有章节标题都要改成中文
  2. 语法章节：函数名大写；参数需要用尖括号包裹
  3. 缺少参数章节
  4. 示例章节：去掉 prompt，即 mysql>; 查询语句和结果应放到两个 code block 中，查询语句使用sql格式，结果使用text格式

hello，参考其他的文件，2，3，4是否应该和其他文件格式保持一致，或者有参考的文件么

https://github.com/apache/doris-website/blob/master/versioned_docs/version-2.1/sql-manual/sql-functions/scalar-functions/numeric-functions/sqrt.md

@CosmosNi
Copy link
Author

CosmosNi commented Feb 6, 2025

@morrySnow PTAL

@morrySnow
Copy link
Contributor

冲突了，需要解决一下

@CosmosNi
Merge remote-tracking branch 'upstream/master' into doc_explode_json_…
6754161 
…array_double

# Conflicts:
#	i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/sql-manual/sql-functions/table-functions/explode-json-array-double.md
@CosmosNi
[doc] translate POSEXPLODE
e0f6a81
@CosmosNi
[doc] translate POSEXPLODE
7c701e3
@CosmosNi CosmosNi requested a review from morrySnow February 6, 2025 14:42
@CosmosNi
Copy link
Author

CosmosNi commented Feb 6, 2025

已解决冲突

@morrySnow morrySnow requested a review from KassieZ February 7, 2025 03:54
@CosmosNi
Copy link
Author

CosmosNi commented Feb 8, 2025

@KassieZ PTAL

@CosmosNi CosmosNi requested a review from morrySnow February 10, 2025 01:01
@CosmosNi
Copy link
Author

@KassieZ PTAL when you have time.

@CosmosNi CosmosNi requested a review from morrySnow February 10, 2025 12:59
morrySnow
morrySnow reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要同步修改sidebar.json中的引用文件名

@CosmosNi
Copy link
Author

sidebar.json

我看文件中已经改过了，是否不需要改了
image

@morrySnow
Copy link
Contributor

sidebar.json

我看文件中已经改过了，是否不需要改了 image

好的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@KassieZ KassieZ Awaiting requested review from KassieZ

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CosmosNi @morrySnow @KassieZ