Minor: Further Clean-up in Enforce Sorting #14732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozankabak
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is a follow-up on #14650. @xudong963 had shown that rather than a change in the plan structure, the only change is possible in node payloads. So,
update_sort_ctx_children()is no longer updating plans. Considering these, the new calls at update_plan_from_children() seem also redundant to me.What changes are included in this PR?
Remove redundant update_plan_from_children() calls in enforce sorting where we know that the plan in the node is consistent with PlanContext children.
Are these changes tested?
Are there any user-facing changes?