Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs TableSource and DefaultTableSource #14665

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 14, 2025

Which issue does this PR close?

Rationale for this change

While reviewing #14631 from @milenkovicm I noticed / was reminded
that the TableSource vs TableProvider split is a bit confusing. It would be nice to have some better docs

What changes are included in this PR?

  1. Update docs for TableSource and DefaultTableSource

Are these changes tested?

By CI and I also reviewed the resulting docs manually

Are there any user-facing changes?

Docs only

@alamb alamb added the documentation Improvements or additions to documentation label Feb 14, 2025
@alamb alamb marked this pull request as ready for review February 14, 2025 13:54
@github-actions github-actions bot added logical-expr Logical plan and expressions core Core DataFusion crate catalog Related to the catalog crate and removed documentation Improvements or additions to documentation labels Feb 14, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@comphead comphead merged commit 78e8493 into apache:main Feb 16, 2025
24 checks passed
@alamb alamb deleted the alamb/better_docs branch February 17, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
catalog Related to the catalog crate core Core DataFusion crate logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants