Fallback to Utf8View for Dict(_, Utf8View) in type_union_resolution_coercion
#14602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
Feb 11, 2025
| new_value_type.map(|t| DataType::Dictionary(index_type.clone(), Box::new(t))) | ||
| match type_union_resolution_coercion(value_type, other_type) { | ||
| // Dict(k, Utf8View) is redundant, Utf8View is good enough | ||
| Some(DataType::Utf8View) => Some(DataType::Utf8View), |
There was a problem hiding this comment.
Possibly also true for binary views (even if I didn't report in my original issue)?
jayzhan211
changed the title
Dict(_, Utf8View) in type_union_resolution_coercionDict(_, ViewType) in type_union_resolution_coercion
alamb
reviewed
Feb 11, 2025
jayzhan211
changed the title
Dict(_, ViewType) in type_union_resolution_coercionDict(_, Utf8View) in type_union_resolution_coercion
|
It seems binary view is problematic, so I remove it for now. Add it if there is test covered |
alamb
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
coalesceleads to type unsupported arrow cast #14581.Rationale for this change
utf8view is good enough, there is no reason we need
dict(_, utf8view).What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?