feat: Implement UNION ALL BY NAME #14538
Open
+522
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
rkrishn7
commented
Feb 10, 2025
| NULL 3 | ||
| 5 NULL | ||
|
|
||
| # TODO: This should pass, but the sanity checker isn't allowing it. |
There was a problem hiding this comment.
A few of the UNION ALL BY NAME tests are failing during the sanity checker. Not completely sure why atm 🤔
rkrishn7
commented
Feb 10, 2025
| @@ -0,0 +1,264 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Most tests here were taken from DuckDB's SLT suite!
There was a problem hiding this comment.
DuckDB to the best of my knowledge is NOT Apache licensed.. Any code or tests taken from them should be licensed appropriately.
There was a problem hiding this comment.
Thank you for catching that @Omega359. Can I include the notice there in conjunction with this header?
|
FYI @berkaysynnada and @berkaysynnada |
|
I ran the sqlite sqllogictests against your branch and it passed so none of those files covered union (all) by name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
UNION [ALL | DISTINCT] BY NAME implementation and associated tests
Are these changes tested?
Yes
Are there any user-facing changes?
Yes, no breaking changes, but new functionality.