Minor: deprecate unused index mod #14534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2010YOUY01
reviewed
Feb 7, 2025
| mod merge; | ||
| pub mod partial_sort; | ||
| pub mod sort; | ||
| pub mod sort_preserving_merge; | ||
| mod stream; | ||
| pub mod streaming_merge; | ||
|
|
||
| pub use index::RowIndex; |
There was a problem hiding this comment.
This is a public struct, we should deprecate it first https://datafusion.apache.org/library-user-guide/api-health.html
By the way, I'm curious is there a way we can detect such unused structs in CI 🤔
There was a problem hiding this comment.
Thank you @2010YOUY01 for review, this is a good point if we can detect such unused structs in CI.
There was a problem hiding this comment.
Addressed in latest PR.
There was a problem hiding this comment.
cargo clippy -- -D dead_code
It seems it can detect the unused code, but we still use the struct in mod, so we can't detect those code.
zhuqi-lucas
force-pushed
the
remove_unused_index
branch
from
ae359da to
4784496
Compare
zhuqi-lucas
changed the title
2010YOUY01
approved these changes
Feb 7, 2025
|
Thanks @zhuqi-lucas @2010YOUY01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is a minor change for remove unused index file and mod.
Are there any user-facing changes?
no