refactor: switch BooleanBufferBuilder to NullBufferBuilder in MaybeNullBufferBuilder #14504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chen-Yuan-Lai
changed the title
|
Looks like there are some CI failures so marking this PR as a draft |
added 2 commits
February 6, 2025 07:06
Chen-Yuan-Lai
force-pushed
the
use_nullbufferbuilder_in_null_builder
branch
from
b5775c5 to
7b14c35
Compare
|
@alamb I found that p.s. I have fixed CI failures, the PR is ready for review : ) |
alamb
approved these changes
Feb 6, 2025
| // BooleanBufferBuilder builder::capacity returns capacity in bits (not bytes) | ||
| Self::Nulls(builder) => builder.capacity() / 8, | ||
| } | ||
| // NullBufferBuilder builder::allocated_size returns capacity in bits |
There was a problem hiding this comment.
Indeed -- I verified this is the case and added some tests here:
| // BooleanBufferBuilder builder::capacity returns capacity in bits (not bytes) | ||
| Self::Nulls(builder) => builder.capacity() / 8, | ||
| } | ||
| // NullBufferBuilder builder::allocated_size returns capacity in bits |
There was a problem hiding this comment.
I actually looked into it more -- I actually think allocated_size returns 8* the actual capacity
|
I also merged this PR up to main to rerun CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14115 .
Rationale for this change
As mentioned in #14115 , several examples in DataFusion codebase still using BooleanBufferBuilder rather than NullBufferBuilder, they should be replaced with NullBufferBuilder for optimization.
What changes are included in this PR?
Most methods in
MaybeNullBufferBuildecan be covered byNullBufferBuilder, so I changed the type fromenumtostructwhich only has oneNullBufferBuilder.Are these changes tested?
Are there any user-facing changes?