-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use StringViewArray
as output of substr
#14498
Conversation
Thank you, it looks good to me. |
Sure. Done. |
Thank you @Kev1n8 and @2010YOUY01 -- I am running some benchmarks on this PR to see if it makes any difference |
My benchmark results show no change in Q22 (but also clearly the data is quite noisy 🤔 )
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me -- thank you @Kev1n8 and @2010YOUY01
I believe this is expected to have no change: The benchmark runs on Parquet, which read to StringView by default. |
Which issue does this PR close?
StringViewArray
as output ofsubstr
when input wasStringArray
#12338Rationale for this change
Generate
StringViewArray
whatever input type is for efficiency.What changes are included in this PR?
substr
, return type is alwaysUtf8View
.datafusion/sqllogictest/test_files/tpch/plans/q22.slt.part
.Are these changes tested?
Yes.
Are there any user-facing changes?
I'm not sure, the return type of substr is fixed to
Utf8View
now.