pre-commit add hook check-shebang-scripts-are-executable for Shell

[jbampton]

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-shebang-scripts-are-executable

Ran chmod +x

Description

This PR...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.07%. Comparing base (fd24509) to head (46e8e50).

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #10150   +/-   ##
=========================================
  Coverage     16.07%   16.07%           
- Complexity    12885    12886    +1     
=========================================
  Files          5642     5642           
  Lines        494039   494039           
  Branches      59912    59912           
=========================================
  Hits          79408    79408           
  Misses       405828   405828           
  Partials       8803     8803           

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	16.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11964

[DaanHoogland]

looks good, I think it is not needed as the package job/installer takes care of these. I see no objections to these anyway.

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12022)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 110826 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10150-t12022-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3640.46	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	3635.99	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	3635.72	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	3634.03	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	3637.90	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	3635.38	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	3653.92	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	3692.68	test_kubernetes_clusters.py
test_04_nonsecured_to_secured_vm_migration	Error	429.54	test_vm_life_cycle.py

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12030)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 110094 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10150-t12030-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3627.78	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	3642.16	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	3641.55	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	3640.39	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	3631.11	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	3642.44	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	3663.33	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	3702.98	test_kubernetes_clusters.py
test_01_redundant_vpc_site2site_vpn	Failure	469.28	test_vpc_vpn.py
test_01_vpc_site2site_vpn	Failure	327.21	test_vpc_vpn.py