-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled the setting reboot.host.and.alert.management.on.heartbeat.timeout
by default
#10111
base: main
Are you sure you want to change the base?
Disabled the setting reboot.host.and.alert.management.on.heartbeat.timeout
by default
#10111
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10111 +/- ##
============================================
- Coverage 15.13% 15.12% -0.01%
+ Complexity 11268 11262 -6
============================================
Files 5408 5408
Lines 473867 473867
Branches 57778 57778
============================================
- Hits 71700 71684 -16
- Misses 394165 394185 +20
+ Partials 8002 7998 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@slavkap , have you tested this with HA enabled? |
@slavkap this changes the current behaviour. |
`reboot.host.and.alert.management.on.heartbeat.timeout` has to be disabled. Even the high availability isn't enabled when there is an issue with a storage CloudStack will reboot the host
79a5f78
to
78180ff
Compare
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
@DaanHoogland, I've tested this with and without HA |
do-not-reboot-host-on-heartbeat-timeout
to not reboot a host on heartbeat timeoutreboot.host.and.alert.management.on.heartbeat.timeout
by default
@slavkap , I changed the title . Hope you don't mind. It was a bit confusing to me. |
@DaanHoogland, I don't mind the change, thanks! |
Description
This PR disables the setting
reboot.host.and.alert.management.on.heartbeat.timeout
. When there is a storage issue, even if the high availability isn't enabled, CloudStack will reboot the host.Types of changes
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?