Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASSGO-53 ObservedQuery.Consistency and ObservedBatch.Consistency fields #1862

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

worryg0d
Copy link
Contributor

@worryg0d worryg0d commented Feb 10, 2025

During retries, consistency of the query may be changed by retry policy implementations (e.g. DowngradingConsistencyRetryPolicy). To observe consistency changes new ObservedQuery.Consistency and ObservedBatch.Consistency fields were added.

Patch by Bohdan Siryk; Reviewed by <> for CASSGO-53

Closes #1798

During retries, consistency of the query may be changed by retry policy implementations (e.g. DowngradingConsistencyRetryPolicy).
To observe consistency changes new ObservedQuery.Consistency and ObservedBatch.Consistency fields were added.

Patch by Bohdan Siryk; Reviewed by <> for CASSGO-53
@joao-r-reis
Copy link
Contributor

Hmm this probably has some overlap with #1447 , I'm going to prototype a bit and see if I can come up with a proposal for some potential API changes to resolve #1447 and these API changes will probably affect this issue/pr (#1862)

@worryg0d
Copy link
Contributor Author

Ah, I see. We want to make Query immutable so changes to consistency won't be mirrored in Query and Batch, but in Iter. However, it shouldn't change this impl a lot

@worryg0d
Copy link
Contributor Author

Some weird things are happening with CI again...

Installing script cli archive...
* Downloading...
curl: (22) The requested URL returned error: 503

'curl --fail --location --progress-bar "${SDKMAN_SERVICE}/broker/download/native/install/${SDKMAN_NATIVE_VERSION}/${SDKMAN_PLATFORM}" > "$sdkman_zip_file"': command failed with exit code 22.
Error: Process completed with exit code 22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Consistency for ObservedQuery
2 participants