Adding support system_traces.coordinator_port and source_port #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| iter := t.session.control.query(`SELECT coordinator, duration | ||
| FROM system_traces.sessions | ||
| WHERE session_id = ?`, traceId) | ||
| iter := t.session.control.query(`SELECT coordinator, duration, coordinator_port |
There was a problem hiding this comment.
We can switch places of duration and coordinator_port fields a little bit:
SELECT coordinator, coordinator_port, duration
It will be more logical to display info about coordinator node this way
Comment on lines
+2145
to
+2147
| iter = t.session.control.query(`SELECT event_id, activity, source, source_elapsed, source_port, thread | ||
| FROM system_traces.events | ||
| WHERE session_id = ?`, traceId) |
There was a problem hiding this comment.
The same is true here. We can change the place of source_port to:
SELECT event_id, activity, source, source_port, source_elapsed, thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The are 2 new columns in Cassandra:
system_traces.sessions.coordinator_port
system_traces.events.source_port
They should be exposed to the user to have the opportunity to check trace info.
https://datastax-oss.atlassian.net/browse/PYTHON-1229
Notice: This fields exists in Cassandra V3 but always equals null, only from Cassandra v4 we can get the ports.
Also, I found some columns from system_traces.sessions that didn`t exposed for user as well yet (client | command | parameters | request | started_at)