Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6818] Write LIMIT for fetch operations in Snowflake #4185

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[CALCITE-6818] Write LIMIT for fetch operations in Snowflake #4185

merged 1 commit into from
Feb 10, 2025
+13 −1

Conversation

xuzifu666
Copy link
Member

@mihaibudiu mihaibudiu added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Feb 7, 2025
ILuffZhe
ILuffZhe approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@ILuffZhe ILuffZhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ILuffZhe ILuffZhe merged commit ed66fcd into apache:main Feb 10, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

@ILuffZhe ILuffZhe ILuffZhe approved these changes

@suibianwanwank suibianwanwank suibianwanwank approved these changes

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuzifu666 @mihaibudiu @ILuffZhe @suibianwanwank