Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUID support in SpannerSchema #34034

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Add UUID support in SpannerSchema #34034

merged 2 commits into from
Feb 20, 2025

Conversation

lagarwal1
Copy link
Contributor

Add support for UUID in SpannerSchema.Column class. This is needed to support UUID in Teleport.
R: @darshan-sj

@darshan-sj
Copy link
Contributor

@Abacn Please review

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@darshan-sj
Copy link
Contributor

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @shunping for label io.
R: @nielm for label spanner.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Feb 20, 2025

org.apache.beam.sdk.io.gcp.bigquery.StorageApiSinkSchemaUpdateIT > testExactlyOnceWithAutoSchemaUpdate[1] FAILED not related to this change.

Going to merge once tests end. Thanks!

@Abacn Abacn merged commit 8031f09 into apache:master Feb 20, 2025
13 of 15 checks passed
wollowizard pushed a commit to wollowizard/beam that referenced this pull request Feb 20, 2025
* Add UUID support in Spanner Schema

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants