Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AlloyDB tests. #33885

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

claudevdm
Copy link
Contributor

@claudevdm claudevdm commented Feb 5, 2025

Also added verbose and skipped reason flags to pytest args to make it clearer which tests ran and got skipped.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Feb 5, 2025
@claudevdm
Copy link
Contributor Author

Run Python_ML PreCommit

@claudevdm claudevdm force-pushed the alloydb-tests-enable2 branch 3 times, most recently from 4a7a846 to cdfa203 Compare February 9, 2025 21:24
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.53%. Comparing base (e1ab2e9) to head (db01964).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33885      +/-   ##
============================================
+ Coverage     57.49%   57.53%   +0.04%     
  Complexity     1474     1474              
============================================
  Files           986      988       +2     
  Lines        156183   156383     +200     
  Branches       1076     1076              
============================================
+ Hits          89793    89976     +183     
- Misses        64175    64192      +17     
  Partials       2215     2215              
Flag Coverage Δ
python 81.20% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudevdm claudevdm force-pushed the alloydb-tests-enable2 branch 5 times, most recently from 2dbb9d4 to 367d6f3 Compare February 10, 2025 12:15
@github-actions github-actions bot added the build label Feb 10, 2025
@claudevdm claudevdm force-pushed the alloydb-tests-enable2 branch 6 times, most recently from 389781d to 5c952d6 Compare February 11, 2025 00:17
@claudevdm claudevdm force-pushed the alloydb-tests-enable2 branch from 5c952d6 to 72cd6e9 Compare February 11, 2025 12:32
@claudevdm
Copy link
Contributor Author

R: @damccorm

@claudevdm claudevdm marked this pull request as ready for review February 11, 2025 19:19
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

…herwise the workflow takes > 3 hours to complete resulting in timeout.
@claudevdm claudevdm force-pushed the alloydb-tests-enable2 branch from ef858d3 to db01964 Compare February 11, 2025 20:27
@damccorm
Copy link
Contributor

Looks like these tests may be failing - https://github.com/apache/beam/actions/runs/13272789857/job/37055921482?pr=33885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants