-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#31438] Non-processing time triggers pass w/accumulation. #33881
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
assign to next reviewer |
As much as I'd love for Jack to look at this as well, he's doing the release and is busy enough. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
I took a quick pass and concluded that I will need some time. This one goes more into Prism details that I am not familiar with than the last one. It might be good for this to be a sit-down review with someone that you want to education about Prism's codebase. |
You're not wrong, but at this point there's unlikely to be a specific person to get this education, due to circumstances. For broad strokes of how it works, it is why I wrote the deep dive, which will need an adjustment for the side channel injected bundles. https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/runners/prism/internal/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly lgtm - I had some minor questions/comments
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go
Outdated
Show resolved
Hide resolved
sdks/go/pkg/beam/runners/prism/internal/jobservices/management.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made. Also added the final "gate" WRT Stateful triggers with merging windows.
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go
Outdated
Show resolved
Hide resolved
sdks/go/pkg/beam/runners/prism/internal/jobservices/management.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - LGTM once checks pass
Thanks for the review! At this stage the next best move is to separate the different stage types, now that there's clarity in how each needs to function. It's fine when there are two different kinds (stateful and not stateful), but aggregation adds sufficient complexity that this won't be as maintainable without much care and reading to know which cyclomatic clause you're dealing with. |
Important notes: Does not support processing time triggers, or triggered side inputs or triggers against merging windows at this PR. Those will be supported at a later PR.
Blocks submission of Processing Time triggers at this time.
Increases the number of Java Validates Runner tests that pass from 325 to 336.
Part of #31438.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.