runtime(go): minimum requirement go1.18 #4754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're proudly using antlr4, but we need to support users who're using go1.18. I found that https://github.com/antlr4-go/antlr/ is using go1.22 while this repos is go1.20 |
|
I'm checking the CI. working on it. |
xiaost
force-pushed
the
rm-x-exp-pkg
branch
2 times, most recently
from
888ca4d to
921fdfa
Compare
golang.org/x/exp, which requires newer go version, is too heavy for previous implementation Signed-off-by: Kyle Xiao <[email protected]>
|
JFYI. |
|
I’m sorry. I thought I was fairly clear that we won’t be going back to
unsupported go releases. You can always make your own fork of course
…On Fri, Jan 10, 2025 at 01:45 Kyle Xiao ***@***.***> wrote:
JFYI.
I also changed CI settings macos-12 -> macos-13
see: actions/runner-images#10721
<actions/runner-images#10721>
—
Reply to this email directly, view it on GitHub
<#4754 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMFRWUZ75FMRD7EQRAD2J53ANAVCNFSM6AAAAABU5UK5PKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRHE3TSMBUGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang.org/x/exp,
which requires newer go version,
is too heavy for previous implementation.
may duplicated with #4688 #4356 #4294, related #4663