Accommodate specified inventory files #4393
Open
+176
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavcrosby
force-pushed
the
add-inventory-option
branch
from
a5e6c76
to
7595e5f
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
7595e5f
to
cfedf17
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
cfedf17
to
9a5e309
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
9a5e309
to
e5eac53
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
e5eac53
to
c5bf8c5
Compare
The ansible_cfg_inventory conditional in the _get_inventory_files method is used because otherwise, when not passing in an inventory file via CLI, inventory_files would set to the /etc/ansible/hosts (the default value for the DEFAULT_HOST_LIST config). In most cases, I'd presume that wouldn't be desired.
cavcrosby
force-pushed
the
add-inventory-option
branch
from
c5bf8c5
to
5f56898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4241 and #4225.
I alluded to this in the former issue, but I believe it was intended that
ansible-lintwould accommodate the inventory files used. Though, for whatever reason, it seems this functionality has been missing.