Allow PHP 8.x in v1 branch

[drastik]

Solves #419

[codecov]

Codecov Report

Merging #420 (db419fc) into v1 (c211986) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                 v1     #420   +/-   ##
=========================================
  Coverage     99.58%   99.58%           
  Complexity      360      360           
=========================================
  Files            20       20           
  Lines           960      960           
=========================================
  Hits            956      956           
  Misses            4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ankitpokhrel]

Hi @drastik, I believe this requires other upgrades as well. For instance, phpunit/phpunit 7.5.20 won't work with PHP8. Any reason you can't upgrade to tus-php@v2 if you are already using PHP8?

[drastik]

@ankitpokhrel Yes, Drupal 9 is PHP 8 but Symfony 4.

[ankitpokhrel]

@drastik I see, thanks!

End of bug fixes for Symfony 4 is November 2022 and the end of security fixes will be on November 2023. PHP7.* and 8.0 has reached its end of life.

I don't know if it would be wise to work on adding support for PHP8 in v1 at this point if this requires a lot of work. I am open for PR tho. Or, perhaps you can maintain a fork for the time being?

[drastik]

I feel ya. Yeah they recommend/soft-require PHP 8.1+, but I wish they hadn't stuck with Symfony 4 at the time of D9 development. I guess we can close this?