add sentinel support #399
add sentinel support #399
Conversation
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage ? 96.24%
Complexity ? 382
=======================================
Files ? 21
Lines ? 1012
Branches ? 0
=======================================
Hits ? 974
Misses ? 38
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
This pull request has been automatically marked as stale because it has not had |
There was a problem hiding this comment.
Hi @beaumind, sorry for reviewing this late and thank you for the PR. I added some comments.
| public function __construct(array $params = [], array $options = []) | ||
| { | ||
| $options = empty($options) ? Config::get('sentinel.options') : $options; | ||
| $params = empty($params) ? Config::get('sentinel.params') : $params; |
There was a problem hiding this comment.
Can we add an example of how sentinel options/params looks like, probably in the README?
| use TusPhp\Config; | ||
| use Predis\Client as RedisClient; | ||
|
|
||
| class RedisSentinelStore extends AbstractCache |
There was a problem hiding this comment.
Looks like this could directly extend RedisStore
| $options = empty($options) ? Config::get('sentinel.options') : $options; | ||
| $params = empty($params) ? Config::get('sentinel.params') : $params; | ||
|
|
||
| $this->redis = new RedisClient($params, $options); |
There was a problem hiding this comment.
If we only need to pass missing option in RedisClient, then we can just update RedisStore to accept second parameter instead of writing a new implementation. This should not break backwards compatibility.
public function __construct(array $options = [], array $params = [])instead of
tus-php/src/Cache/RedisStore.php
Line 19 in 2067142
No description provided.